RecentRunner/group-2-threaded-project-petshop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lock all stateful mutations #313

Merged
RecentRunner merged 2 commits from worktree-fix-refund-idempotency into main 2026-04-15 16:02:37 -06:00
Conversation 0 Commits 2 Files Changed 17 +115 -363
RecentRunner commented 2026-04-15 16:02:32 -06:00 (Migrated from github.com)
Copy Link

Summary

  • Pessimistic write locks on inventory, user, cart, coupon, pet, and password reset token rows to eliminate race conditions across all stateful endpoints
  • Coupon usage limit now re-checked at sale creation time (inside the lock)
  • AuthController.updateProfile made @Transactional so the user row lock is held for the full update
  • DataIntegrityViolationException caught in register and profile update → clean 409 instead of 500
  • Migration V6: unique constraint on users.phone as DB-level backstop

Test plan

  • Concurrent sale requests for the same low-stock product should not oversell
  • Simultaneous loyalty point redemptions should not double-discount
  • Double-submitting checkout confirmation should not create duplicate sales
  • Concurrent coupon applications at the usage limit should reject the second
  • Two adoption requests for the same pet should only create one pending record
  • Double-submitting a password reset form should not apply the token twice
  • Registering with a duplicate phone number returns 409
## Summary - Pessimistic write locks on inventory, user, cart, coupon, pet, and password reset token rows to eliminate race conditions across all stateful endpoints - Coupon usage limit now re-checked at sale creation time (inside the lock) - `AuthController.updateProfile` made `@Transactional` so the user row lock is held for the full update - `DataIntegrityViolationException` caught in register and profile update → clean 409 instead of 500 - Migration V6: unique constraint on `users.phone` as DB-level backstop ## Test plan - [ ] Concurrent sale requests for the same low-stock product should not oversell - [ ] Simultaneous loyalty point redemptions should not double-discount - [ ] Double-submitting checkout confirmation should not create duplicate sales - [ ] Concurrent coupon applications at the usage limit should reject the second - [ ] Two adoption requests for the same pet should only create one pending record - [ ] Double-submitting a password reset form should not apply the token twice - [ ] Registering with a duplicate phone number returns 409
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
android
backend
bug
Something isn't working
 data
desktop
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 presentation
question
Further information is requested
 website
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
RecentRunner
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RecentRunner/group-2-threaded-project-petshop#313
Delete Branch "worktree-fix-refund-idempotency"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?