RecentRunner/group-2-threaded-project-petshop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Backend bug fixes #314

Merged
RecentRunner merged 4 commits from bug-fixes into main 2026-04-15 16:08:23 -06:00
Conversation 0 Commits 4 Files Changed 18 +153 -469
RecentRunner commented 2026-04-15 16:05:32 -06:00 (Migrated from github.com)
Copy Link

Summary

  • Fix admin 403 on sales, adoption sourceStoreId validation, refund total sign, sale item quantity validation
  • Fix missing auth on store write endpoints, appointment status case mismatch, contact controller error handling, PetRequest equals bug
  • Fix ServiceRequest duration validation, ChatController 500 on missing message, appointment status blank string
  • Decouple email sending from transactions using Spring event system

Test plan

  • Admin can create sales
  • Creating adoption without sourceStoreId returns 400
  • Refund amounts are negative
  • Store create/update/delete requires ADMIN role
  • Past appointments get status "Completed" not "COMPLETED"
  • Missing message returns 404 not 500
  • Emails are not sent when a transaction rolls back
## Summary - Fix admin 403 on sales, adoption sourceStoreId validation, refund total sign, sale item quantity validation - Fix missing auth on store write endpoints, appointment status case mismatch, contact controller error handling, PetRequest equals bug - Fix ServiceRequest duration validation, ChatController 500 on missing message, appointment status blank string - Decouple email sending from transactions using Spring event system ## Test plan - [ ] Admin can create sales - [ ] Creating adoption without sourceStoreId returns 400 - [ ] Refund amounts are negative - [ ] Store create/update/delete requires ADMIN role - [ ] Past appointments get status "Completed" not "COMPLETED" - [ ] Missing message returns 404 not 500 - [ ] Emails are not sent when a transaction rolls back
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
android
backend
bug
Something isn't working
 data
desktop
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 presentation
question
Further information is requested
 website
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
RecentRunner
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RecentRunner/group-2-threaded-project-petshop#314
Delete Branch "bug-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?